GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/22701
[SPARK-25690][SQL] Analyzer rule HandleNullInputsForUDF does not stabilize
and can be applied infinitely
## What changes were proposed in this pull request?
The HandleNullInputsForUDF rule can generate new If node infinitely, thus
causing problems like match of SQL cache missed.
This was fixed in SPARK-24891 and was then broken by SPARK-25044.
The unit test in `AnalysisSuite` added in SPARK-24891 should have failed
but didn't because it wasn't properly updated after the `ScalaUDF` constructor
signature change. So this PR also updates the test accordingly based on the new
`ScalaUDF` constructor.
## How was this patch tested?
Updated the original UT. This should be justified as the original UT became
invalid after SPARK-25044.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maryannxue/spark spark-25690
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22701.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22701
----
commit 736625b3f280dcd6caed83b3cec82b72d4f0c0fc
Author: maryannxue <maryannxue@...>
Date: 2018-10-11T16:45:28Z
[SPARK-25690][SQL] Analyzer rule HandleNullInputsForUDF does not stabilize
and can be applied infinitely
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
