Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22701#discussion_r224658264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2150,8 +2150,10 @@ class Analyzer(
// TODO: skip null handling for not-nullable primitive inputs
after we can completely
// trust the `nullable` information.
+ val needsNullCheck = (nullable: Boolean, expr: Expression) =>
--- End diff --
Yes, that's because "nullableType" is flipped around here. "nullableType"
should really be "cantBeNull" or "doesntNeedNullCheck". I'll change this in
other PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
