Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22706#discussion_r224692031
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -152,10 +152,10 @@ abstract class UnaryNode extends LogicalPlan {
       override final def children: Seq[LogicalPlan] = child :: Nil
     
       /**
    -   * Generates an additional set of aliased constraints by replacing the 
original constraint
    -   * expressions with the corresponding alias
    +   * Generates all valid constraints including an set of aliased 
constraints by replacing the
    +   * original constraint expressions with the corresponding alias
        */
    -  protected def getAliasedConstraints(projectList: Seq[NamedExpression]): 
Set[Expression] = {
    +  protected def getAllValidConstraints(projectList: Seq[NamedExpression]): 
Set[Expression] = {
    --- End diff --
    
    cc @gatorsmile .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to