Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22709#discussion_r224831076
  
    --- Diff: 
external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala 
---
    @@ -67,21 +71,28 @@ object SchemaConverters {
           case ENUM => SchemaType(StringType, nullable = false)
     
           case RECORD =>
    +        if (existingRecordNames.contains(avroSchema.getFullName)) {
    --- End diff --
    
    Another approach is to check the whole json string 
schema(`avroSchema.toString`) here. But it seems overkill. Avro requires the 
full name of record to be unique.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to