Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21990#discussion_r224984813
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala 
---
    @@ -86,6 +86,7 @@ class SparkSession private(
     
       private[sql] def this(sc: SparkContext) {
         this(sc, None, None, new SparkSessionExtensions)
    +    SparkSession.applyExtensionsFromConf(sc.getConf, this.extensions)
    --- End diff --
    
    Let's add some comments why this is only here in this constructor. It might 
look weird why this constructor specifically requires to run 
`applyExtensionsFromConf` alone.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to