GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/22732
[SPARK-25044][FOLLOW-UP] Change ScalaUDF constructor signature
## What changes were proposed in this pull request?
This is a follow-up PR for #22259. The extra field added in `ScalaUDF` with
the original PR was declared optional, but should be indeed required, otherwise
callers of `ScalaUDF`'s constructor could ignore this new field and cause the
result to be incorrect.
Meanwhile, now that we have this extra field indicating if a null-test
should be applied on the corresponding input value, we can also make use of
this flag to avoid the rule `HandleNullInputsForUDF` being applied infinitely.
## How was this patch tested?
Passed affected existing UTs:
AnalysisSuite
UDFSuite
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maryannxue/spark spark-25044-followup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22732.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22732
----
commit 5cf3c898978388dc9700219aa6e82c24d5f52f33
Author: maryannxue <maryannxue@...>
Date: 2018-10-15T18:36:00Z
Adjust ScalaUDF constructor signature
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
