Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22728#discussion_r225298840
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/count.sql ---
    @@ -0,0 +1,21 @@
    +-- Test data.
    +CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES
    +(1, 1), (1, 2), (2, 1), (1, 1), (null, 2), (1, null), (null, null)
    +AS testData(a, b);
    +
    +-- count with single expression
    +SELECT count(a), count(b), count(a + b), count((a, b)) FROM testData;
    +
    +-- distinct count with single expression
    +SELECT
    +  count(DISTINCT a),
    +  count(DISTINCT b),
    +  count(DISTINCT (a + b)),
    +  count(DISTINCT (a, b))
    +FROM testData;
    +
    +-- count with multiple expressions
    +SELECT count(a, b), count(b, a), count(testData.*) FROM testData;
    --- End diff --
    
    Please also include `count(*)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to