Github user dwmclary commented on a diff in the pull request:
https://github.com/apache/spark/pull/3213#discussion_r20406513
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDD.scala ---
@@ -131,6 +134,68 @@ class SchemaRDD(
*/
lazy val schema: StructType = queryExecution.analyzed.schema
+ /** Transforms a single Row to JSON using Jackson
+ *
+ * @param jf a JsonFactory object to construct a JsonGenerator
+ * @param rowSchema the schema object used for conversion
+ * @param row The row to convert
+ */
+ private def rowToJSON(rowSchema: StructType, jf: JsonFactory)(row: Row):
String = {
--- End diff --
Done and done @davies, @yhaui
On Sat, Nov 15, 2014 at 5:17 PM, Yin Huai <[email protected]> wrote:
> In sql/core/src/main/scala/org/apache/spark/sql/SchemaRDD.scala:
>
> > @@ -131,6 +134,68 @@ class SchemaRDD(
> > */
> > lazy val schema: StructType = queryExecution.analyzed.schema
> >
> > + /** Transforms a single Row to JSON using Jackson
> > + *
> > + * @param jf a JsonFactory object to construct a JsonGenerator
> > + * @param rowSchema the schema object used for conversion
> > + * @param row The row to convert
> > + */
> > + private def rowToJSON(rowSchema: StructType, jf: JsonFactory)(row:
Row): String = {
>
> How about to rename jf to jsonFactory?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3213/files#r20406459>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
