Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3121#discussion_r20413870
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -21,9 +21,62 @@ import org.scalatest.FunSuite
import org.apache.hadoop.io.BytesWritable
-class SparkContextSuite extends FunSuite {
- //Regression test for SPARK-3121
+class SparkContextSuite extends FunSuite with LocalSparkContext {
+
+ /** Allows system properties to be changed in tests */
+ private def withSystemProperty[T](property: String, value:
String)(block: => T): T = {
--- End diff --
Yeah, it might be nice to move this into a test utilities object /
subpackage, along with LocalSparkContext, SharedSparkContext, my
systemproperties DI code, etc. Let's do this in a separate JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
