Github user huaxingao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22295#discussion_r226178191
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -3863,6 +3863,145 @@ def test_jvm_default_session_already_set(self):
                 spark.stop()
     
     
    +class SparkSessionTests2(unittest.TestCase):
    +
    +    def test_active_session(self):
    +        spark = SparkSession.builder \
    +            .master("local") \
    +            .getOrCreate()
    +        try:
    +            activeSession = SparkSession.getActiveSession()
    +            df = activeSession.createDataFrame([(1, 'Alice')], ['age', 
'name'])
    +            self.assertEqual(df.collect(), [Row(age=1, name=u'Alice')])
    +        finally:
    +            spark.stop()
    +
    +    def test_get_active_session_when_no_active_session(self):
    +        active = SparkSession.getActiveSession()
    +        self.assertEqual(active, None)
    +        spark = SparkSession.builder \
    +            .master("local") \
    +            .getOrCreate()
    +        active = SparkSession.getActiveSession()
    +        self.assertEqual(active, spark)
    +        spark.stop()
    +        active = SparkSession.getActiveSession()
    +        self.assertEqual(active, None)
    +
    +    def test_SparkSession(self):
    +        spark = SparkSession.builder \
    +            .master("local") \
    +            .config("some-config", "v2") \
    +            .getOrCreate()
    +        try:
    +            self.assertEqual(spark.conf.get("some-config"), "v2")
    +            self.assertEqual(spark.sparkContext._conf.get("some-config"), 
"v2")
    +            self.assertEqual(spark.version, spark.sparkContext.version)
    +            spark.sql("CREATE DATABASE test_db")
    +            spark.catalog.setCurrentDatabase("test_db")
    +            self.assertEqual(spark.catalog.currentDatabase(), "test_db")
    +            spark.sql("CREATE TABLE table1 (name STRING, age INT) USING 
parquet")
    +            self.assertEqual(spark.table("table1").columns, ['name', 
'age'])
    +            self.assertEqual(spark.range(3).count(), 3)
    +        finally:
    +            spark.stop()
    +
    +    def test_global_default_session(self):
    +        spark = SparkSession.builder \
    +            .master("local") \
    +            .getOrCreate()
    +        try:
    +            self.assertEqual(SparkSession.builder.getOrCreate(), spark)
    +        finally:
    +            spark.stop()
    +
    +    def test_default_and_active_session(self):
    +        spark = SparkSession.builder \
    +            .master("local") \
    +            .getOrCreate()
    +        activeSession = spark._jvm.SparkSession.getActiveSession()
    +        defaultSession = spark._jvm.SparkSession.getDefaultSession()
    +        try:
    +            self.assertEqual(activeSession, defaultSession)
    +        finally:
    +            spark.stop()
    +
    +    def test_config_option_propagated_to_existing_SparkSession(self):
    --- End diff --
    
    Will change. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to