Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22598#discussion_r226235800
  
    --- Diff: 
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSecurityHelperSuite.scala
 ---
    @@ -0,0 +1,129 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.kafka010
    +
    +import java.util.UUID
    +
    +import org.apache.hadoop.security.{Credentials, UserGroupInformation}
    +import org.apache.hadoop.security.token.Token
    +import org.scalatest.BeforeAndAfterEach
    +
    +import org.apache.spark.{SparkConf, SparkFunSuite}
    +import org.apache.spark.internal.config.{KAFKA_KERBEROS_SERVICE_NAME, 
KEYTAB, PRINCIPAL}
    +import 
org.apache.spark.sql.kafka010.TokenUtil.KafkaDelegationTokenIdentifier
    +
    +class KafkaSecurityHelperSuite extends SparkFunSuite with 
BeforeAndAfterEach {
    +  private val keytab = "/path/to/keytab"
    +  private val kerberosServiceName = "kafka"
    +  private val principal = "u...@domain.com"
    +  private val tokenId = "tokenId" + UUID.randomUUID().toString
    +  private val tokenPassword = "tokenPassword" + UUID.randomUUID().toString
    +
    +  private var sparkConf: SparkConf = null
    +
    +  override def beforeEach(): Unit = {
    +    super.beforeEach()
    +    sparkConf = new SparkConf()
    --- End diff --
    
    If you are playing with UGI in tests, its usually safest to 
call`UserGroupInformation.reset()` during setup and teardown; this empties out 
all existing creds and avoids problems with >1 test in the same JVM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to