Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22764#discussion_r226387346
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -310,4 +317,6 @@ class BisectingKMeansSummary private[clustering] (
         predictionCol: String,
         featuresCol: String,
         k: Int,
    -    numIter: Int) extends ClusteringSummary(predictions, predictionCol, 
featuresCol, k, numIter)
    +    numIter: Int,
    +    @Since("2.4.0") val trainingCost: Double)
    --- End diff --
    
    I wouldn't consider this as mandatory. I think what is mandatory to target 
for 2.4 is to deprecate the `computeCost` method. But I think it is a nice to 
have, since it is a non-deprecated way users have to access this information. 
In the PR related to `KMeans`, there was quite a discussion about it and it was 
considered to be part of the deprecation change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to