Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r226522081
--- Diff: core/src/main/scala/org/apache/spark/Heartbeater.scala ---
@@ -59,12 +60,13 @@ private[spark] class Heartbeater(
heartbeater.awaitTermination(10, TimeUnit.SECONDS)
}
- /**
- * Get the current executor level metrics. These are returned as an
array, with the index
- * determined by MetricGetter.values
- */
+ /** Get the current executor level metrics. These are returned as a Map
*/
def getCurrentMetrics(): ExecutorMetrics = {
- val metrics =
ExecutorMetricType.values.map(_.getMetricValue(memoryManager)).toArray
+ // figure out how to append all the metrics
--- End diff --
this is a strange comment ... is this a TODO?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
