Github user ankurdave commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3303#discussion_r20420549
  
    --- Diff: 
graphx/src/main/scala/org/apache/spark/graphx/impl/GraphImpl.scala ---
    @@ -336,8 +337,8 @@ object GraphImpl {
        */
       def fromExistingRDDs[VD: ClassTag, ED: ClassTag](
           vertices: VertexRDD[VD],
    -      edges: EdgeRDD[ED, VD]): GraphImpl[VD, ED] = {
    -    new GraphImpl(vertices, new ReplicatedVertexView(edges))
    +      edges: EdgeRDD[ED]): GraphImpl[VD, ED] = {
    +    new GraphImpl(vertices, new 
ReplicatedVertexView(edges.asInstanceOf[EdgeRDDImpl[ED, VD]]))
    --- End diff --
    
    Unfortunately, here we have to remove the statically-checked constraint 
that the cached vertices in `edges` are of the correct type (`VD`). Preserving 
this static constraint would require fromExistingRDDs to take an EdgeRDDImpl, 
which would be a breaking change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to