Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r226874107
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +246,33 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMethod("show", "SparkDataFrame",
function(object) {
- cols <- lapply(dtypes(object), function(l) {
- paste(l, collapse = ":")
- })
- s <- paste(cols, collapse = ", ")
- cat(paste(class(object), "[", s, "]\n", sep = ""))
+ allConf <- sparkR.conf()
+ prop <- allConf[["spark.sql.repl.eagerEval.enabled"]]
+ if (!is.null(prop) && identical(prop, "true")) {
+ argsList <- list()
+ argsList$x <- object
+ prop <- allConf[["spark.sql.repl.eagerEval.maxNumRows"]]
+ if (!is.null(prop)) {
+ numRows <- as.numeric(prop)
+ if (numRows > 0) {
+ argsList$numRows <- numRows
--- End diff --
could you manually check if this works correctly when numRows or truncate
(L265) is a numeric but not an integer - eg. 1.4
if not, we should replace `as.numeric` than `as.integer` in both places
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
