Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3296#discussion_r20455498
--- Diff: core/src/main/scala/org/apache/spark/deploy/ClientArguments.scala
---
@@ -116,12 +114,5 @@ private[spark] class ClientArguments(args:
Array[String]) {
}
object ClientArguments {
- def isValidJarUrl(s: String): Boolean = {
- try {
- val uri = new URI(s)
- uri.getScheme != null && uri.getAuthority != null &&
s.endsWith("jar")
--- End diff --
I think it would be better to just remove the `uri.getAuthority` check
instead, since that will get you better validation of input parameters than
your regex.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
