Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22760#discussion_r227065151
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/KubernetesFeaturesTestUtils.scala
 ---
    @@ -63,4 +63,40 @@ object KubernetesFeaturesTestUtils {
       def containerHasEnvVar(container: Container, envVarName: String): 
Boolean = {
         container.getEnv.asScala.exists(envVar => envVar.getName == envVarName)
       }
    +
    +  def podHasLabels(pod: Pod, labels: Map[String, String]): Boolean = {
    +    labels.toSet.subsetOf(pod.getMetadata.getLabels.asScala.toSet)
    +  }
    +
    +  // Kerberos Specific Test utils
    +
    +  // Upon use of bootstrapHadoopConfDir
    +  def hConfBootPod(inputPod: SparkPod): SparkPod =
    --- End diff --
    
    Can we just name it `hadoopConfBootPod`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to