Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22790#discussion_r227152309
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
 ---
    @@ -126,7 +126,7 @@ object BisectingKMeansModel extends 
Loader[BisectingKMeansModel] {
             val model = SaveLoadV1_0.load(sc, path)
             model
           case (SaveLoadV2_0.thisClassName, SaveLoadV2_0.thisFormatVersion) =>
    -        val model = SaveLoadV1_0.load(sc, path)
    +        val model = SaveLoadV2_0.load(sc, path)
    --- End diff --
    
    This is not a regression, but it looks like a correctness or data loss 
issue at Spark 2.4.0 new feature.
    Do you know why https://issues.apache.org/jira/browse/SPARK-23412 is 
created as a `Minor` and `Documentation` issue?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to