Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227202171
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -140,6 +141,14 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
val input = fileToString(new File(testCase.inputFile))
val (comments, code) = input.split("\n").partition(_.startsWith("--"))
+
+ // Runs all the tests on both codegen-only and interpreter modes.
Since explain results differ
+ // when `WHOLESTAGE_CODEGEN_ENABLED` disabled, we don't run these
tests now.
+ val codegenConfigSets = Array(("false", "NO_CODEGEN"), ("true",
"CODEGEN_ONLY")).map {
+ case (wholeStageCodegenEnabled, codegenFactoryMode) =>
+ Array( // SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key ->
wholeStageCodegenEnabled,
--- End diff --
If `wholeStageCodegenEnabled` is not used, let's not complicate the code
now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
