Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22778#discussion_r227208719
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
 ---
    @@ -33,23 +34,44 @@ class RewriteSubquerySuite extends PlanTest {
           Batch("Rewrite Subquery", FixedPoint(1),
             RewritePredicateSubquery,
             ColumnPruning,
    +        InferFiltersFromConstraints,
    +        PushDownPredicate,
             CollapseProject,
             RemoveRedundantProject) :: Nil
       }
     
       test("Column pruning after rewriting predicate subquery") {
    -    val relation = LocalRelation('a.int, 'b.int)
    -    val relInSubquery = LocalRelation('x.int, 'y.int, 'z.int)
    +    withSQLConf(SQLConf.CONSTRAINT_PROPAGATION_ENABLED.key -> "false") {
    --- End diff --
    
    Yes, `spark.sql.constraintPropagation.enabled=false` to test 
`ColumnPruning`.
    `spark.sql.constraintPropagation.enabled=true` to test `ColumnPruning`, 
`InferFiltersFromConstraints` and `PushDownPredicate`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to