Github user sryza commented on the pull request:

    https://github.com/apache/spark/pull/3302#issuecomment-63362140
  
    I don't entirely understand that line of argument.  Why would we want to 
place a lower bound if the data structure is pushing the memory threshold?  I 
filed https://issues.apache.org/jira/browse/SPARK-4456 to figure this out and 
document it better.
    
    This patch LGTM though.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to