Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3009#issuecomment-63367682
> I just have one comment about the code, which is that the code for
AllStagesPage.scala and JobPage.scala is very similar and I think should be
factored into a shared function that accepts a list of stages.
The pages are very similar now, but I expect the job page to eventually
expand to include other features, such as DAG visualizations, etc. I think
there's only about 60 lines of near-duplicate code, so I'm not sure that it's
worth it to put this behind a helper function, especially since there are some
other edge-cases / areas of divergence that we would also need to handle (for
example, the all stages page has a "Total duration" field which lists the
SparkContext's creation time, but I don't think this is appropriate for a job
details page).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
