Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22791#discussion_r227465232
--- Diff: examples/src/main/r/RSparkSQLExample.R ---
@@ -114,7 +114,7 @@ write.df(namesAndAges, "namesAndAges.parquet",
"parquet")
# $example on:manual_load_options_csv$
-df <- read.df("examples/src/main/resources/people.csv", "csv")
+df <- read.df("examples/src/main/resources/people.csv", "csv", sep=";",
inferSchema=T, header=T)
--- End diff --
in R style we typical put space after param name, ie.
https://github.com/apache/spark/pull/22791/files#diff-eeffb959b904ebb5c864bc3dafe6437dR168
`, sep = ";", inferSchema = TRUE, header = TRUE`
and pls don't use `T` for readability
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
