Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22809#discussion_r228143956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
---
@@ -57,3 +57,34 @@ case class Max(child: Expression) extends
DeclarativeAggregate {
override lazy val evaluateExpression: AttributeReference = max
}
+
+abstract class AnyAggBase(arg: Expression)
--- End diff --
can we change this to something like `UnevaluableBooleanAggBase` and make
also `EveryAgg` extend this, in order to avoid code duplication?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
