Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228163049
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala
---
@@ -21,32 +21,30 @@ import org.apache.spark.benchmark.Benchmark
/**
* Benchmark to measure performance for wide table.
- * To run this:
- * build/sbt "sql/test-only *benchmark.BenchmarkWideTable"
- *
- * Benchmarks in this file are skipped in normal builds.
+ * {{{
+ * To run this benchmark:
+ * 1. without sbt: bin/spark-submit --class <this class> <spark sql test
jar>
+ * 2. build/sbt "sql/test:runMain <this class>"
+ * 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt
"sql/test:runMain <this class>"
+ * Results will be written to
"benchmarks/BenchmarkWideTable-results.txt".
+ * }}}
*/
-class BenchmarkWideTable extends BenchmarkWithCodegen {
+object BenchmarkWideTable extends SqlBasedBenchmark {
--- End diff --
`BenchmarkWideTable` -> `WideTableBenchmark`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
