Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/21063#discussion_r228223151
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
---
@@ -111,7 +112,12 @@ trait ProgressReporter extends Logging {
logDebug("Starting Trigger Calculation")
lastTriggerStartTimestamp = currentTriggerStartTimestamp
currentTriggerStartTimestamp = triggerClock.getTimeMillis()
- currentStatus = currentStatus.copy(isTriggerActive = true)
+ // isTriggerActive field is kept false for ContinuousExecution
+ // since it is tied to MicroBatchExecution
+ this match {
--- End diff --
For me a bit strange that `ProgressReporter` as a base for
`MicroBatchExecution` and `ContinuousExecution` contains an implementation
which is only good for `MicroBatchExecution` and overriden only in
`ContinuousExecution`. I mean why providing an implementation here which is
only good for one of the inherited class and why not letting it to be just an
abstract method here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
