Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228387605
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -910,12 +910,14 @@ class CodegenContext {
val blocks = new ArrayBuffer[String]()
val blockBuilder = new StringBuilder()
var length = 0
+ val splitThreshold =
+ SQLConf.get.getConfString("spark.testing.codegen.splitThreshold",
"1024").toInt
--- End diff --
@wangyum Thanks for the suggestion! You prefer to modifying
`CodeGenerator.scala` each time run this benchmark, right? I feel it could be
kind of tricky to let user modify codes and if the `CodeGenerator.scala`
changes in the future, it is hard to update the document here. @dongjoon-hyun
@gengliangwang any suggestion?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
