Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22820#discussion_r228458281
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
 ---
    @@ -157,7 +157,9 @@ private[spark] object KubernetesUtils {
           }.getOrElse(Seq(("container state", "N/A")))
       }
     
    -  def formatTime(time: Time): String = {
    -    if (time != null) time.getTime else "N/A"
    +  def formatTime(time: String): String = {
    +    // TODO: Investigate form `time` comes in as there was a DataType
    +    // change from Time to String
    --- End diff --
    
    The string returned is ISO8601 format so no need to do anything special here


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to