Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r228470004
--- Diff:
resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh
---
@@ -71,19 +71,36 @@ if [[ $IMAGE_TAG == "N/A" ]];
then
IMAGE_TAG=$(uuidgen);
cd $UNPACKED_SPARK_TGZ
- if [[ $DEPLOY_MODE == cloud ]] ;
- then
- $UNPACKED_SPARK_TGZ/bin/docker-image-tool.sh -r $IMAGE_REPO -t
$IMAGE_TAG build
- if [[ $IMAGE_REPO == gcr.io* ]] ;
- then
- gcloud docker -- push $IMAGE_REPO/spark:$IMAGE_TAG
- else
- $UNPACKED_SPARK_TGZ/bin/docker-image-tool.sh -r $IMAGE_REPO -t
$IMAGE_TAG push
- fi
- else
- # -m option for minikube.
- $UNPACKED_SPARK_TGZ/bin/docker-image-tool.sh -m -r $IMAGE_REPO -t
$IMAGE_TAG build
- fi
+
+ case $DEPLOY_MODE in
+ cloud|cloud-url)
+ # Build images
+ $UNPACKED_SPARK_TGZ/bin/docker-image-tool.sh -r $IMAGE_REPO -t
$IMAGE_TAG build
+
+ # Push images appropriately
+ if [[ $IMAGE_REPO == gcr.io* ]] ;
+ then
+ gcloud docker -- push $IMAGE_REPO/spark:$IMAGE_TAG
+ else
+ $UNPACKED_SPARK_TGZ/bin/docker-image-tool.sh -r $IMAGE_REPO -t
$IMAGE_TAG push
+ fi
+ ;;
+
+ docker-for-desktop)
--- End diff --
Now corrected
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
