GitHub user shaneknapp opened a pull request:

    https://github.com/apache/spark/pull/22854

    [SPARK-25854] fix mvn to not always exit 1

    ## What changes were proposed in this pull request?
    
    the final line in the mvn helper script in build/ attempts to shut down the 
zinc server.  due to the zinc server being set up w/a 30min timeout, by the 
time the mvn test instantiation finishes, the server times out.
    
    this means that when the mvn script tries to shut down zinc, it returns 
w/an exit code of 1.  this will then automatically fail the entire build (even 
if the build passes).
    
    ## How was this patch tested?
    
    i set up a test build:
    
https://amplab.cs.berkeley.edu/jenkins/job/sknapp-testing-spark-branch-2.4-test-maven-hadoop-2.7/
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shaneknapp/spark fix-mvn-helper-script

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22854
    
----
commit 2f0a91b64ee312bb5fb33885118afac4b7d0dc91
Author: shane knapp <incomplete@...>
Date:   2018-10-26T16:01:30Z

    fix mvn to not always exit 1

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to