Github user shaneknapp commented on a diff in the pull request: https://github.com/apache/spark/pull/22854#discussion_r228607477 --- Diff: build/mvn --- @@ -163,8 +163,14 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"} echo "Using \`mvn\` from path: $MVN_BIN" 1>&2 -# Last, call the `mvn` command as usual +# call the `mvn` command as usual "${MVN_BIN}" -DzincPort=${ZINC_PORT} "$@" +MVN_RETCODE=$? -# Try to shut down zinc explicitly -"${ZINC_BIN}" -shutdown -port ${ZINC_PORT} +# SPARK-25854 +# Try to shut down zinc explicitly if the server is still running. if it's not running, +# it's timed out and we'll still need to exit the script w/a 0 to keep the build from +# failing. +"${ZINC_BIN}" -shutdown -port ${ZINC_PORT} || true --- End diff -- we probably don't need it, but i am more than comfortable keeping it in there #justincase
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org