Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22843#discussion_r228701116
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3477,39 +3447,6 @@ test_that("Window functions on a DataFrame", {
expect_equal(result, expected)
})
-test_that("createDataFrame sqlContext parameter backward compatibility", {
- sqlContext <- suppressWarnings(sparkRSQL.init(sc))
- a <- 1:3
- b <- c("a", "b", "c")
- ldf <- data.frame(a, b)
- # Call function with namespace :: operator - SPARK-16538
- df <- suppressWarnings(SparkR::createDataFrame(sqlContext, ldf))
- expect_equal(columns(df), c("a", "b"))
- expect_equal(dtypes(df), list(c("a", "int"), c("b", "string")))
- expect_equal(count(df), 3)
- ldf2 <- collect(df)
- expect_equal(ldf$a, ldf2$a)
-
- df2 <- suppressWarnings(createDataFrame(sqlContext, iris))
- expect_equal(count(df2), 150)
- expect_equal(ncol(df2), 5)
-
- df3 <- suppressWarnings(read.df(sqlContext, jsonPath, "json"))
- expect_is(df3, "SparkDataFrame")
- expect_equal(count(df3), 3)
-
- before <- suppressWarnings(createDataFrame(sqlContext, iris))
- after <- suppressWarnings(createDataFrame(iris))
- expect_equal(collect(before), collect(after))
-
- # more tests for SPARK-16538
- createOrReplaceTempView(df, "table")
- SparkR::listTables()
- SparkR::sql("SELECT 1")
--- End diff --
I added back some calls with SparkR:: but really this is now standard R call
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
