Github user dwmclary commented on a diff in the pull request:
https://github.com/apache/spark/pull/3213#discussion_r20479917
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/json/JsonSuite.scala
---
@@ -779,4 +780,52 @@ class JsonSuite extends QueryTest {
Seq(null, null, null, Seq(Seq(null, Seq(1, 2, 3)))) :: Nil
)
}
+
+ test("SPARK-4228 SchemaRDD to JSON")
+ {
--- End diff --
I'm already working on it. Shouldn't take too much longer.
On Mon, Nov 17, 2014 at 5:12 PM, Yin Huai <notificati...@github.com> wrote:
> In sql/core/src/test/scala/org/apache/spark/sql/json/JsonSuite.scala:
>
> > @@ -779,4 +780,52 @@ class JsonSuite extends QueryTest {
> > Seq(null, null, null, Seq(Seq(null, Seq(1, 2, 3)))) :: Nil
> > )
> > }
> > +
> > + test("SPARK-4228 SchemaRDD to JSON")
> > + {
>
> Move it to the line above.
>
> Also, can you make changes according to @marmbrus
> <https://github.com/marmbrus>'s comments on tests (round-trip our
> existing datasets with this code path)?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3213/files#r20479487>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
