Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/3302#discussion_r20487011
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/Spillable.scala ---
@@ -36,7 +36,11 @@ private[spark] trait Spillable[C] {
protected def spill(collection: C): Unit
// Number of elements read from input since last spill
- protected var elementsRead: Long
+ protected var elementsRead: Long = 0
+
+ // subclass calls this method to notify reading an element
+ // it's used to check spilling frequency
+ protected def addElementsRead = elementsRead += 1
--- End diff --
Add parentheses to this and call it with `addElementsRead()` since it has
side effects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
