Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22906#discussion_r229723135
  
    --- Diff: 
core/src/test/scala/org/apache/spark/io/CompressionCodecSuite.scala ---
    @@ -128,6 +130,69 @@ class CompressionCodecSuite extends SparkFunSuite {
         }
       }
     
    +  test("SPARK-25895 Zstd shuffle Read/Write/spill comparison w.r.t lz4") {
    --- End diff --
    
    How about add a benchmark? You can check our all benchmarks here:: 
https://issues.apache.org/jira/browse/SPARK-25475


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to