Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22855#discussion_r229739685
--- Diff:
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
@@ -456,9 +458,63 @@ class KryoSerializerSuite extends SparkFunSuite with
SharedSparkContext {
// Regression test for SPARK-7766, an issue where disabling auto-reset
and enabling
// reference-tracking would lead to corrupted output when serializer
instances are re-used
- for (referenceTracking <- Set(true, false); autoReset <- Set(true,
false)) {
- test(s"instance reuse with autoReset = $autoReset, referenceTracking =
$referenceTracking") {
- testSerializerInstanceReuse(autoReset = autoReset, referenceTracking
= referenceTracking)
+ for {
+ referenceTracking <- Set(true, false)
+ autoReset <- Set(true, false)
+ usePool <- Set(true, false)
+ } {
+ test(s"instance reuse with autoReset = $autoReset, referenceTracking =
$referenceTracking" +
+ s", usePool = $usePool") {
+ testSerializerInstanceReuse(
+ autoReset = autoReset, referenceTracking = referenceTracking,
usePool = usePool)
--- End diff --
Likewise i see this is just how the code was written before but the `foo =
foo` style isn't adding anything IMHO. Feel free to not name args
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
