Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22608#discussion_r230227737
  
    --- Diff: dev/make-distribution.sh ---
    @@ -191,7 +191,8 @@ fi
     # Only create and copy the dockerfiles directory if the kubernetes 
artifacts were built.
     if [ -d "$SPARK_HOME"/resource-managers/kubernetes/core/target/ ]; then
       mkdir -p "$DISTDIR/kubernetes/"
    -  cp -a 
"$SPARK_HOME"/resource-managers/kubernetes/docker/src/main/dockerfiles 
"$DISTDIR/kubernetes/"
    +  cp -a "$SPARK_HOME"/resource-managers/kubernetes/docker/src 
"$DISTDIR/kubernetes/"
    +  cp -a 
"$SPARK_HOME"/resource-managers/kubernetes/integration-tests/scripts 
"$DISTDIR/kubernetes/"
    --- End diff --
    
    This is following the existing pattern in the line below; but is there a 
purpose in packaging these test artifacts with a binary Spark distribution?
    
    Seems to me like they should be left in the source package and that's it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to