Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3195#discussion_r20526916
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -655,33 +663,44 @@ def wait_for_cluster_state(cluster_instances, 
cluster_state, opts):
                (would be nice to replace this with a proper enum: 
http://stackoverflow.com/a/1695250)
         """
         sys.stdout.write(
    -        "Waiting for all instances in cluster to enter '{s}' 
state.".format(s=cluster_state)
    +        "Waiting for cluster to enter '{s}' state.".format(s=cluster_state)
         )
         sys.stdout.flush()
     
    -    num_attempts = 0
    +    start_time = datetime.now()
    +
    +    conn = ec2.connect_to_region(opts.region)
    --- End diff --
    
    We seem to be passing around `conn` across functions in the existing 
script. Any reason to not do that and create a new one here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to