Github user KyleLi1985 commented on the issue:

    https://github.com/apache/spark/pull/22893
  
    > OK, the Spark part doesn't seem relevant. The input might be more 
realistic here, yes. I was commenting that your test code doesn't show what 
you're testing, though I understand you manually modified it. Because the test 
is so central here I think it's important to understand exactly what you're 
measuring and exactly what you're running.
    > 
    > This doesn't show an improvement, right?
    
    TEST, I agree with you
    
    No influence for sparse case


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to