Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3342#discussion_r20536236
--- Diff: project/SparkBuild.scala ---
@@ -101,14 +101,10 @@ object SparkBuild extends PomBuild {
v.split("(\\s+|,)").filterNot(_.isEmpty).map(_.trim.replaceAll("-P",
"")).toSeq
}
- if (profiles.exists(_.contains("scala-"))) {
- profiles
- } else if (System.getProperty("scala-2.11") != null) {
- profiles ++ Seq("scala-2.11")
- } else {
- println("Enabled default scala profile")
- profiles ++ Seq("scala-2.10")
+ if (System.getProperty("scala-2.11") != null &&
System.getProperty("scala-2.11") == "") {
--- End diff --
Yes, we need the property value is not empty.
sbt build works with `-Dscala-2.11=true`, but does not work with only
`-Dscala-2.11`.
Ah, you are right, the first condition is not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
