Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22944#discussion_r230781583
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala 
---
    @@ -1556,6 +1556,14 @@ class DatasetSuite extends QueryTest with 
SharedSQLContext {
           df.where($"city".contains(new java.lang.Character('A'))),
           Seq(Row("Amsterdam")))
       }
    +
    +  test("SPARK-25942: typed aggregation on primitive data") {
    --- End diff --
    
    It should not be introduced recently. I think we encode primitive data as a 
`value` field at beginning. 
    
    Because `AppendColumns` takes serializers' named expressions as 
`newColumns`. For primitive data, it conflicts with original data attribute 
`value`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to