Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/22880#discussion_r231047086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -202,11 +204,15 @@ private[parquet] class ParquetRowConverter(
override def start(): Unit = {
var i = 0
- while (i < currentRow.numFields) {
+ while (i < fieldConverters.length) {
fieldConverters(i).updater.start()
currentRow.setNullAt(i)
--- End diff --
I see. I think doing this separately is better and you can rewrite it to
one-liner, like for setNullAt:
```scala
(0 until currentRow.numFields).foreach(currentRow.setNullAt)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
