Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22921#discussion_r231125506
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) { 
standardGeneric("add_months") })
     
     #' @rdname column_aggregate_functions
     #' @name NULL
    -setGeneric("approxCountDistinct", function(x, ...) { 
standardGeneric("approxCountDistinct") })
    +setGeneric("approx_count_distinct", function(x, ...) { 
standardGeneric("approx_count_distinct") })
    --- End diff --
    
    It is, but then again that's exactly what was deprecated and removed in 
Python and Scala. Major versions can have breaking changes. Yes R isn't always 
in sync but that's a bug not a feature? Let me surface this to dev@ as I think 
it's going to come up a few more times.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to