Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22855#discussion_r231526925
--- Diff:
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
@@ -214,8 +230,14 @@ class KryoSerializer(conf: SparkConf)
kryo
}
+ override def setDefaultClassLoader(classLoader: ClassLoader): Serializer
= {
+ defaultClassLoader = Some(classLoader)
--- End diff --
You can write `super.setDefaultClassLoader(classLoader)` here to inherit
the behavior rather than duplicate it. It is just one line now, yes.
Where is defaultClassLoader used in this implementation though? I wonder
why it matters that you call `getPool` after this field is set. And if it does,
isn't setting it in line 105 not actually helping?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
