GitHub user gengliangwang opened a pull request:

    https://github.com/apache/spark/pull/22965

    [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark/DataSourceReadBenchmark 
case names and execution instructions

    ## What changes were proposed in this pull request?
    
    1. OrcReadBenchmark is under hive module, so the way to run it should be 
    ```
    build/sbt "hive/test:runMain <this class>"
    ```
    
    2. The benchmark "String with Nulls Scan" should be with case "String with 
Nulls Scan(5%/50%/95%)", not "(0.05%/0.5%/0.95%)"
    
    3. Add the null value percentages in the test case names of 
DataSourceReadBenchmark, for the benchmark "String with Nulls Scan" .
    
    
    ## How was this patch tested?
    
    Re-run benchmarks

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gengliangwang/spark fixHiveOrcReadBenchmark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22965.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22965
    
----
commit f282331d12975687391a7648aacde19a58774936
Author: Gengliang Wang <gengliang.wang@...>
Date:   2018-11-07T13:03:05Z

    fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to