Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22951#discussion_r231646713
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CsvExpressionsSuite.scala
 ---
    @@ -209,4 +210,20 @@ class CsvExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper with P
           "2015-12-31T16:00:00"
         )
       }
    +
    +  test("take into account locale while parsing date") {
    --- End diff --
    
    nit. Can we use more simple test case names like the following?
    ```
    `take into account locale while parsing date` -> `parse date with locale`
    `use locale while parsing timestamps` -> `parse timestamps with locale`
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to