Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22965#discussion_r231795384
  
    --- Diff: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ---
    @@ -2,268 +2,268 @@
     SQL Single Numeric Column Scan
     
================================================================================================
     
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     SQL Single TINYINT Column Scan:          Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -SQL CSV                                     21508 / 22112          0.7     
   1367.5       1.0X
    -SQL Json                                      8705 / 8825          1.8     
    553.4       2.5X
    -SQL Parquet Vectorized                         157 /  186        100.0     
     10.0     136.7X
    -SQL Parquet MR                                1789 / 1794          8.8     
    113.8      12.0X
    -SQL ORC Vectorized                             156 /  166        100.9     
      9.9     138.0X
    -SQL ORC Vectorized with copy                   218 /  225         72.1     
     13.9      98.6X
    -SQL ORC MR                                    1448 / 1492         10.9     
     92.0      14.9X
    -
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +SQL CSV                                     14108 / 14263          1.1     
    896.9       1.0X
    +SQL Json                                      5477 / 5509          2.9     
    348.2       2.6X
    +SQL Parquet Vectorized                         115 /  125        137.1     
      7.3     122.9X
    +SQL Parquet MR                                1318 / 1332         11.9     
     83.8      10.7X
    +SQL ORC Vectorized                             150 /  159        104.9     
      9.5      94.1X
    +SQL ORC Vectorized with copy                   206 /  208         76.4     
     13.1      68.5X
    +SQL ORC MR                                    1072 / 1075         14.7     
     68.1      13.2X
    +
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     Parquet Reader Single TINYINT Column Scan: Best/Avg Time(ms)    Rate(M/s)  
 Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -ParquetReader Vectorized                       202 /  211         77.7     
     12.9       1.0X
    -ParquetReader Vectorized -> Row                118 /  120        133.5     
      7.5       1.7X
    +ParquetReader Vectorized                       138 /  152        114.0     
      8.8       1.0X
    +ParquetReader Vectorized -> Row                 80 /   87        197.2     
      5.1       1.7X
     
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     SQL Single SMALLINT Column Scan:         Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -SQL CSV                                     23282 / 23312          0.7     
   1480.2       1.0X
    -SQL Json                                      9187 / 9189          1.7     
    584.1       2.5X
    -SQL Parquet Vectorized                         204 /  218         77.0     
     13.0     114.0X
    -SQL Parquet MR                                1941 / 1953          8.1     
    123.4      12.0X
    -SQL ORC Vectorized                             217 /  225         72.6     
     13.8     107.5X
    -SQL ORC Vectorized with copy                   279 /  289         56.3     
     17.8      83.4X
    -SQL ORC MR                                    1541 / 1549         10.2     
     98.0      15.1X
    -
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +SQL CSV                                     14495 / 14507          1.1     
    921.6       1.0X
    +SQL Json                                      5615 / 5668          2.8     
    357.0       2.6X
    +SQL Parquet Vectorized                         147 /  154        107.4     
      9.3      98.9X
    +SQL Parquet MR                                1431 / 1454         11.0     
     91.0      10.1X
    +SQL ORC Vectorized                             170 /  175         92.4     
     10.8      85.1X
    +SQL ORC Vectorized with copy                   223 /  228         70.6     
     14.2      65.1X
    +SQL ORC MR                                    1187 / 1197         13.2     
     75.5      12.2X
    +
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     Parquet Reader Single SMALLINT Column Scan: Best/Avg Time(ms)    Rate(M/s) 
  Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -ParquetReader Vectorized                       288 /  297         54.6     
     18.3       1.0X
    -ParquetReader Vectorized -> Row                255 /  257         61.7     
     16.2       1.1X
    +ParquetReader Vectorized                       190 /  219         82.8     
     12.1       1.0X
    +ParquetReader Vectorized -> Row                165 /  169         95.2     
     10.5       1.1X
     
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     SQL Single INT Column Scan:              Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -SQL CSV                                     24990 / 25012          0.6     
   1588.8       1.0X
    -SQL Json                                      9837 / 9865          1.6     
    625.4       2.5X
    -SQL Parquet Vectorized                         170 /  180         92.3     
     10.8     146.6X
    -SQL Parquet MR                                2319 / 2328          6.8     
    147.4      10.8X
    -SQL ORC Vectorized                             293 /  301         53.7     
     18.6      85.3X
    -SQL ORC Vectorized with copy                   297 /  309         52.9     
     18.9      84.0X
    -SQL ORC MR                                    1667 / 1674          9.4     
    106.0      15.0X
    -
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +SQL CSV                                     16105 / 16214          1.0     
   1023.9       1.0X
    +SQL Json                                      6289 / 6291          2.5     
    399.8       2.6X
    +SQL Parquet Vectorized                         142 /  148        111.0     
      9.0     113.6X
    +SQL Parquet MR                                1797 / 1801          8.8     
    114.2       9.0X
    +SQL ORC Vectorized                             232 /  238         67.9     
     14.7      69.5X
    +SQL ORC Vectorized with copy                   237 /  242         66.5     
     15.0      68.1X
    +SQL ORC MR                                    1309 / 1409         12.0     
     83.2      12.3X
    +
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     Parquet Reader Single INT Column Scan:   Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -ParquetReader Vectorized                       257 /  274         61.3     
     16.3       1.0X
    -ParquetReader Vectorized -> Row                259 /  264         60.8     
     16.4       1.0X
    +ParquetReader Vectorized                       181 /  225         87.0     
     11.5       1.0X
    +ParquetReader Vectorized -> Row                180 /  186         87.4     
     11.4       1.0X
     
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +Java HotSpot(TM) 64-Bit Server VM 1.8.0_131-b11 on Mac OS X 10.13.6
    +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
     SQL Single BIGINT Column Scan:           Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
     
------------------------------------------------------------------------------------------------
    -SQL CSV                                     32537 / 32554          0.5     
   2068.7       1.0X
    -SQL Json                                    12610 / 12668          1.2     
    801.7       2.6X
    -SQL Parquet Vectorized                         258 /  276         61.0     
     16.4     126.2X
    -SQL Parquet MR                                2422 / 2435          6.5     
    154.0      13.4X
    -SQL ORC Vectorized                             378 /  385         41.6     
     24.0      86.2X
    -SQL ORC Vectorized with copy                   381 /  389         41.3     
     24.2      85.4X
    -SQL ORC MR                                    1797 / 1819          8.8     
    114.3      18.1X
    -
    -OpenJDK 64-Bit Server VM 1.8.0_181-b13 on Linux 3.10.0-862.3.2.el7.x86_64
    -Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
    +SQL CSV                                     20128 / 20682          0.8     
   1279.7       1.0X
    +SQL Json                                      8277 / 8279          1.9     
    526.3       2.4X
    +SQL Parquet Vectorized                         198 /  211         79.3     
     12.6     101.5X
    +SQL Parquet MR                                1788 / 1816          8.8     
    113.7      11.3X
    +SQL ORC Vectorized                             273 /  290         57.6     
     17.4      73.7X
    --- End diff --
    
    Yes 👍 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to