Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22975#discussion_r231978035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVHeaderChecker.scala
---
@@ -67,8 +69,8 @@ class CSVHeaderChecker(
var (nameInSchema, nameInHeader) = (fieldNames(i),
columnNames(i))
if (!caseSensitive) {
// scalastyle:off caselocale
- nameInSchema = nameInSchema.toLowerCase
- nameInHeader = nameInHeader.toLowerCase
+ nameInSchema = nameInSchema.toLowerCase(Locale.ROOT)
--- End diff --
These may be user-supplied column names so I think it has to be
locale-sensitive
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
