Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22967#discussion_r232033587
--- Diff: pom.xml ---
@@ -2717,7 +2717,6 @@
<rules>
<bannedDependencies>
<excludes combine.children="append">
- <exclude>*:*_2.11</exclude>
<exclude>*:*_2.10</exclude>
--- End diff --
Not quite -- the rule has to stay on the 2.12 profile, because it's the one
that needs to exclude _2.11 dependencies. The exclusion for _2.10 is already in
the parent rule and can be removed. But that's the only change here.
Yes the version changes look right.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
