Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22612#discussion_r232222970
  
    --- Diff: 
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
    @@ -95,10 +148,18 @@ private[spark] object ExecutorMetricType {
         OnHeapUnifiedMemory,
         OffHeapUnifiedMemory,
         DirectPoolMemory,
    -    MappedPoolMemory
    +    MappedPoolMemory,
    +    ProcessTreeMetrics
       )
     
    -  // Map of executor metric type to its index in values.
    -  val metricIdxMap =
    -    Map[ExecutorMetricType, Int](ExecutorMetricType.values.zipWithIndex: 
_*)
    +  var definedMetricsAndOffset = mutable.LinkedHashMap.empty[String, Int]
    --- End diff --
    
    this can be a `val`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to